Repository navigation
refactor: share official runtime install handling - #1004
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR shares official runtime installation and output handling between the runtime and release commands. Example: Repeat
Review scores
ProductKind: Refactor · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR makes a focused consolidation that is absent from main, with no introduced correctness or security defect found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherCLI handlers validate selectors and pass installation options to RuntimeService, which prepares managed runtime files and returns metadata plus an installed, reused, or updated action for rendering. flowchart TD
A[Runtime install command] --> C[Shared install helper]
B[Release install command] --> C
C --> D[Host readiness check]
D --> E[RuntimeService preparation]
E --> F[Managed runtime store]
E --> G[JSON or action receipt]
Technical reviewBest possible solution: Retain this focused extraction with command-specific validation in the callers and installation behavior owned by the existing RuntimeService. Do we have a high-confidence way to reproduce the issue? There is no reported user-facing bug to reproduce; the pinned main source directly confirms duplicated official-install handling. Is this the best way to solve the issue? The helper is a small, appropriate extraction: it uses the existing options type and service owner while preserving validation, output profiles, progress, error propagation, and exit codes. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7abac7dfb8b7. Provenance checked
TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 5, 2026, 5:22 AM ET / 10:22 UTC. |
What Problem This Solves
Official runtime installation is handled twice in the CLI, making the two entry points harder to maintain consistently.
User Impact
No user-visible change.
runtime installandrelease installretain their own validation messages, host preparation, progress, JSON output, and installed/reused/updated receipts.Why This Change Was Made
Share the execution and output path through one internal helper using the existing install options. Local-path, URL, and manifest installs remain unchanged. No dependency, version, service, or release-automation changes.
Evidence